firebase / FirebaseUI-Android

Optimized UI components for Firebase
https://firebaseopensource.com/projects/firebase/firebaseui-android/
Apache License 2.0
4.63k stars 1.84k forks source link

High crash rate (NPE) acessing com.firebase.ui.auth.AuthUI.getInstance #1126

Closed RuiVarela closed 6 years ago

RuiVarela commented 6 years ago

Step 1: Are you in the right place?

Yes

Step 2: Describe your environment

Step 3: Describe the problem:

Hi All, we are currently experiencing an high crash rate using firebase ui, the current snippet

      m_activity.startActivityForResult(
                AuthUI.getInstance()
                        .createSignInIntentBuilder()
                        .setIsSmartLockEnabled(false)
                        .setAvailableProviders(Arrays.asList(new AuthUI.IdpConfig.PhoneBuilder().build()))
                        .build(),
                REQUEST_LOGIN_PHONE);

produces erratically the following issue,

Fatal Exception: java.lang.NullPointerException: Attempt to invoke virtual method 'com.google.android.gms.tasks.Task com.google.android.gms.common.api.GoogleApi.zzb(com.google.android.gms.common.api.internal.zzdd)' on a null object reference
       at com.google.android.gms.internal.zzdvv.zzb(Unknown Source)
       at com.google.android.gms.internal.zzdwc.setFirebaseUIVersion(Unknown Source)
       at com.google.firebase.auth.FirebaseAuth.signOut(Unknown Source)
       at com.firebase.ui.auth.AuthUI.(AuthUI.java)
       at com.firebase.ui.auth.AuthUI.getInstance(AuthUI.java:244)
       at com.firebase.ui.auth.AuthUI.getInstance(AuthUI.java:232)
       at co.triller.droid.Activities.Login.LoginController.connectPhone(LoginController.java:1280)
       at co.triller.droid.Activities.Main.SplashLoginFragment$4.onClick(SplashLoginFragment.java:104)
       at android.view.View.performClick(View.java:5721)
       at android.view.View$PerformClick.run(View.java:22620)
       at android.os.Handler.handleCallback(Handler.java:739)
       at android.os.Handler.dispatchMessage(Handler.java:95)
       at android.os.Looper.loop(Looper.java:148)
       at android.app.ActivityThread.main(ActivityThread.java:7409)
       at java.lang.reflect.Method.invoke(Method.java)
       at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1230)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1120)

here is the more detailed info from crashlitics http://crashes.to/s/a80689a7452

this issue is out top crash with an impact of 0.27% on out app, any advice, or workaround for this?

vanleeuwenbram commented 6 years ago

some extra info in the issue that already exists: https://github.com/firebase/FirebaseUI-Android/issues/1104

samtstern commented 6 years ago

This is a duplicate of #1104, let's discuss there.