search

firebase / FirebaseUI-Android

Optimized UI components for Firebase
https://firebaseopensource.com/projects/firebase/firebaseui-android/
Apache License 2.0
4.63k stars 1.84k forks source link

Supporting all Firebase auth providers (Play Games and GitHub) #1196

Open pushbit opened 6 years ago

pushbit commented 6 years ago

Are there any plans to add support for the remaining two Firebase auth providers - Play Games (new) and GitHub? I'm particularly interested in the Play Games provider because I believe it allows a much lower friction sign in experience compared to the Google provider with the Games scope because it does not supply any personal information (just a player nickname) and therefore requires less (if any) manual user authorisation.

https://firebase.google.com/docs/auth/android/play-games

SUPERCILEX commented 6 years ago

Oh hey, Sam and I were just talking about this a week or two ago. It looks like there's demand for it, so yeah, I don't see why we shouldn't add the Play Games provider. @samtstern Any objections? As for GitHub, I have an issue open here and a branch with half-broken code that I keep trying to figure out. If you know someone who's done auth from Chrome Custom Tabs, I'd love to talk with them! Otherwise, I'll just have to suck it up one of these day and do a deep dive into the Facebook SDK to see how they've done it. 😉

samtstern commented 6 years ago

@pushbit this is definitely something we'd like to support, but I want to finish all of the stability work and let that soak for a little before we dive into new providers (which naturally come with new bugs).

So we can put this on the backlog for now.

SUPERCILEX commented 6 years ago

We should also support link sign up though that will require much more effort and thought since we've got to do dynamic link stuff.

SUPERCILEX commented 6 years ago

@pushbit GitHub support is coming: https://github.com/firebase/FirebaseUI-Android/issues/346

samtstern commented 5 years ago

FYI GitHub support shipped in 4.2.0