firebase / FirebaseUI-Android

Optimized UI components for Firebase
https://firebaseopensource.com/projects/firebase/firebaseui-android/
Apache License 2.0
4.63k stars 1.83k forks source link

Can't customize 'account disabled' string in auth UI #1815

Open hkchakladar opened 4 years ago

hkchakladar commented 4 years ago

When the user is blocked in the console, the UI show hard coded string: The user account has been disabled by an administrator

I need to customize this string.

I have tried adding this <string name="account_disabled">Account is disabled by the administrator</string> from (https://github.com/firebase/FirebaseUI-Android/blob/master/app/src/main/res/values/strings.xml#L78) to mystrings.xml, but this didn't works.

<string name="account_disabled" ... is not available in the customizable strings for auth (https://github.com/firebase/FirebaseUI-Android/blob/master/auth/src/main/res/values/strings.xml)

samtstern commented 4 years ago

Those errors come from here: https://github.com/firebase/FirebaseUI-Android/blob/d78e72bf12a7af9a7ae11f167764682b792f9c4b/auth/src/main/java/com/firebase/ui/auth/ErrorCodes.java#L85

You're right that they're not currently translated, they should only appear in certain failure cases. It would be good for us to get them translated, but will also be a lot of work in re architecting error handling.