firebase / FirebaseUI-Flutter

Apache License 2.0
99 stars 86 forks source link

[firebase_ui_localizations] Turkish Translation Mistake #10

Closed atillaturkmen closed 1 year ago

atillaturkmen commented 1 year ago

Bug report

The Turkish translation for the "registerActionText" and "registerText" texts are incorrect in the firebase_ui_tr.arb file. The current translation says "Kaydet" for "registerActionText" and "Kaydedin" for "registerText" but the correct translations should be "Kaydol" and "Kaydolun" respectively.

Steps to reproduce

Steps to reproduce the behavior:

  1. Open the application in Turkish language.
  2. Navigate to the registration page or perform any registration action.
  3. Observe the text for the "registerActionText" and "registerText" strings.

Expected behavior

The expected behavior is that the "registerActionText" should be translated as "Kaydol" and the "registerText" message should be translated as "Kaydolun."

danagbemava-nc commented 1 year ago

I see the lines here https://github.com/firebase/flutterfire/blob/d98b24fe21f5a02552aedac4ef4db45cda02520e/packages/firebase_ui_localizations/lib/src/lang/tr.dart#L171 & here https://github.com/firebase/flutterfire/blob/d98b24fe21f5a02552aedac4ef4db45cda02520e/packages/firebase_ui_localizations/lib/src/lang/tr.dart#L177

atillaturkmen commented 1 year ago

I see the lines here

https://github.com/firebase/flutterfire/blob/d98b24fe21f5a02552aedac4ef4db45cda02520e/packages/firebase_ui_localizations/lib/src/lang/tr.dart#L171

& here https://github.com/firebase/flutterfire/blob/d98b24fe21f5a02552aedac4ef4db45cda02520e/packages/firebase_ui_localizations/lib/src/lang/tr.dart#L177

I have changed these lines as well as this line https://github.com/firebase/flutterfire/blob/d98b24fe21f5a02552aedac4ef4db45cda02520e/packages/firebase_ui_localizations/lib/l10n/firebase_ui_tr.arb#L263 and this line https://github.com/firebase/flutterfire/blob/d98b24fe21f5a02552aedac4ef4db45cda02520e/packages/firebase_ui_localizations/lib/l10n/firebase_ui_tr.arb#L273

in the relevant PR.

lesnitsky commented 1 year ago

Fixed by https://github.com/firebase/flutterfire/pull/11339