fix(firebase_ui_oauth): Fix provider auth listener late init exception

Rexios80 commented 10 months ago

Description

It's possible for the provider to get recreated when the button rebuilds. Since the authListener is set in initState it only happens the first time. Any auth methods called on the provider after the second rebuild will throw a late initialization error since the authListener will not be set. This PR adds code to store the provider in the state so that it cannot get reset externally.

I also set the isLoading to false in the onError callback otherwise the button will get stuck in a loading state when there is an error.

Related Issues

I don't see one

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[x] All existing and new tests are passing.
[x] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (melos run analyze) does not report any problems on my PR.
[x] All unit tests pass (melos run test:unit:all doesn't fail).
[x] I read and followed the Flutter Style Guide.
[x] I signed the CLA.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change.
[x] No, this is not a breaking change.

Rexios80 commented 10 months ago

Not sure why the CI is failing. I think it's trying to run tests that don't exist?

Rexios80 commented 10 months ago

Yeah the test file for firebase_ui_oauth_example is empty

Rexios80 commented 10 months ago

@lesnitsky Do you have an ETA on releasing this to pub.dev?

firebase / FirebaseUI-Flutter