firebase / FirebaseUI-Flutter

Apache License 2.0
106 stars 94 forks source link

fix(ui_localizations): loading Traditional Chinese #128

Closed LaemonT closed 11 months ago

LaemonT commented 1 year ago

Description

I found that the firebase_ui_localizations package includes a translation for Taiwan (ZhTWLocalizations), but has not been used appropriately. So I follow the same approach of how the flutter_localizations package gets the appropriate translation and how to fallback when the scriptCode or countryCode is not defined.

Related Issues

Closes #33

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

lesnitsky commented 1 year ago

@gary6lin Thanks for submitting a PR! Could you please add unit tests verifying that traditional Chinese loads correctly now? Also might be good to add a test verifying that localization overrides still work. Unit test under firebase_ui_localizations package should be fine.

lesnitsky commented 12 months ago

@gary6lin could you please run melos run format to make code_health/format green.