Closed LaemonT closed 11 months ago
@gary6lin Thanks for submitting a PR! Could you please add unit tests verifying that traditional Chinese loads correctly now? Also might be good to add a test verifying that localization overrides still work. Unit test under firebase_ui_localizations
package should be fine.
@gary6lin could you please run melos run format
to make code_health/format
green.
Description
I found that the
firebase_ui_localizations
package includes a translation for Taiwan (ZhTWLocalizations
), but has not been used appropriately. So I follow the same approach of how theflutter_localizations
package gets the appropriate translation and how to fallback when thescriptCode
orcountryCode
is not defined.Related Issues
Closes #33
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process. Updating thepubspec.yaml
and changelogs is not required.///
).melos run analyze
) does not report any problems on my PR.melos run test:unit:all
doesn't fail).Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?