feat(ui_localization): Add the translations for the da,nb,sv - Githubissues

firebase / FirebaseUI-Flutter

Apache License 2.0

92 stars 81 forks source link

feat(ui_localization): Add the translations for the da,nb,sv #175

Closed asimjawad closed 7 months ago

asimjawad commented 8 months ago

Description

Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[x] All existing and new tests are passing.
[x] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (melos run analyze) does not report any problems on my PR.
[x] All unit tests pass (melos run test:unit:all doesn't fail).
[x] I read and followed the Flutter Style Guide.
[x] I signed the CLA.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change.
[x] No, this is not a breaking change.

lesnitsky commented 7 months ago

@asimjawad could you please ask someone else you know who speaks Norsk, Swedish, and Danish to proofread this and approve?

asimjawad commented 7 months ago

@lesnitsky I got some people in my company who can do that, let me take the translation files through them and I will get back to you

lesnitsky commented 7 months ago

@asimjawad any updates on getting this PR reviewed by someone else who speaks these languages?

asimjawad commented 7 months ago

@lesnitsky yeah, I asked people in my company who speaks the following languages, they have given me the updated jsons for these, I will be updating the PR soon, can you merge it then?

lesnitsky commented 7 months ago

@asimjawad could you please ask those people to approve this PR as well?

asimjawad commented 7 months ago

@lesnitsky they are laymen, basically, I do know a guy who speaks polish and a dev, I can ask him to approve it

lesnitsky commented 7 months ago

@asimjawad the localization is not for polish though

asimjawad commented 7 months ago

@lesnitsky sorry for that, I have been working for 12 hours straight XD

I am out of options then, I can try one of my teammates, who speak these languages, but are not developers.

lesnitsky commented 7 months ago

We can't merge it without proofreading, feel free to re-submit if you can find someone who can approve this PR.

martinsellergren commented 2 months ago

Swedish looks good (I'm a native speaker). This update would be great.

asimjawad commented 2 months ago

@martinsellergren let me see in my free time if I still have the code somewhere on the pc