firebase / FirebaseUI-Flutter

Apache License 2.0
105 stars 94 forks source link

feat(firebase_ui_database): Allow reversing the database query #193

Closed Rexios80 closed 10 months ago

Rexios80 commented 10 months ago

Description

Adds a reverseQuery option to FirebaseDatabaseQueryBuilder

Related Issues

N/A

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

lesnitsky commented 10 months ago

@Rexios80 could you please merge the latest main into your branch?

lesnitsky commented 10 months ago

@Rexios80 could you please resolve a conflict and merge the latest main again please?

rrousselGit commented 10 months ago

Hello!

Some tests would be great. Otherwise lgtm

Rexios80 commented 10 months ago

There are no existing tests for the Database UI widgets. Since this is a small change, I believe adding those tests is outside the scope of this PR.

rrousselGit commented 10 months ago

Oh I saw that you did it for database. We'd want to do it for Firestore too.

Rexios80 commented 10 months ago

Firestore queries have built-in support for reversal

rrousselGit commented 10 months ago

You're right, we could use orderBy/descending. LGTM then