firebase / FirebaseUI-Flutter

Apache License 2.0
92 stars 80 forks source link

fix(ui_auth): make light text on _EmailVerificationBadge legible #196

Open qwezey opened 7 months ago

qwezey commented 7 months ago

Description

Related Issues

This PR resolves issue #18

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

EArminjon commented 7 months ago

I think it could be better to expose this color through a dedicated parameter. In fact, it could be good to have the possibility to override every UI widget of this package to custom them as close as client app current design. It could be really fantastic to be able to have the hand on every things :/ !

qwezey commented 7 months ago

@EArminjon For this PR, do you think I should allow the client to override the whole decoration property of the Container or only the color property of the BoxDecoration?

EArminjon commented 7 months ago

I'm not a maintainer, it's just a global question around this package and maybe the real fix behind this needs.

lesnitsky commented 7 months ago

it could be good to have the possibility to override every UI widget of this package to custom them as close as client app current design.

Styling API is in place and contributions on making anything configurable are welcome.

In general, here's how styling should be taken care of:

In this specific issue, we could create an EmailVerificationBadgeStyle object and have a configurable backgroundColor defined there.

@qwezey would you be willing to update your PR accordingly?

russellwheatley commented 2 months ago

Hey @qwezey - will you be following up on this PR?

cmjordan42 commented 2 months ago

@lesnitsky @russellwheatley Can we proceed with merging this PR? It is a bug fix but requests to incorporate non-critical enhancements seem to be stalling it. We are at a 0 currently and this change seems like it would get us to a 1, so it seems prudent to keep any enhancements to get to a 2 separate from this.