Open qwezey opened 7 months ago
I think it could be better to expose this color through a dedicated parameter. In fact, it could be good to have the possibility to override every UI widget of this package to custom them as close as client app current design. It could be really fantastic to be able to have the hand on every things :/ !
@EArminjon For this PR, do you think I should allow the client to override the whole decoration
property of the Container
or only the color
property of the BoxDecoration
?
I'm not a maintainer, it's just a global question around this package and maybe the real fix behind this needs.
it could be good to have the possibility to override every UI widget of this package to custom them as close as client app current design.
Styling API is in place and contributions on making anything configurable are welcome.
In general, here's how styling should be taken care of:
applyToMaterialTheme
or applyToCupertinoTheme
if necessary (see this example)Set<FirebaseUIStyle> styles
on a screen level (like here)FirebaseUIStyle.ofType<T extends FirebaseUIStyle>
(like here) to get a relevant style object from build contextIn this specific issue, we could create an EmailVerificationBadgeStyle
object and have a configurable backgroundColor
defined there.
@qwezey would you be willing to update your PR accordingly?
Hey @qwezey - will you be following up on this PR?
@lesnitsky @russellwheatley Can we proceed with merging this PR? It is a bug fix but requests to incorporate non-critical enhancements seem to be stalling it. We are at a 0 currently and this change seems like it would get us to a 1, so it seems prudent to keep any enhancements to get to a 2 separate from this.
Description
Related Issues
This PR resolves issue #18
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process. Updating thepubspec.yaml
and changelogs is not required.///
).melos run analyze
) does not report any problems on my PR.melos run test:unit:all
doesn't fail).Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?