fix(ui_auth, ui_localizations): add localization label (#229)

apnnux commented 6 months ago

Description

Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[x] All existing and new tests are passing.
[x] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (melos run analyze) does not report any problems on my PR.
[x] All unit tests pass (melos run test:unit:all doesn't fail).
[x] I read and followed the Flutter Style Guide.
[x] I signed the CLA.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change.
[x] No, this is not a breaking change.

russellwheatley commented 5 months ago

Hey @apnnux - you need to follow these instruction for adding this new label here: https://github.com/firebase/FirebaseUI-Flutter/blob/main/packages/firebase_ui_localizations/README.md#adding-a-new-language

In other words, you need to update the arb files for each language and generate the code based on the arb file. Once that is done, we can look to get this Pr approved. Thanks!

russellwheatley commented 2 months ago

Hey @apnnux - are you going to follow up on this PR?

apnnux commented 2 months ago

Hi @russellwheatley yes, I'm sorry but in this moment I'm not at home, but in a few days I'll update this

firebase / FirebaseUI-Flutter