firebase / FirebaseUI-Flutter

Apache License 2.0
91 stars 79 forks source link

fix: Arabic translation of Sign In With Apple button label #265

Closed MahMoos closed 4 months ago

MahMoos commented 5 months ago

Description

Currently the label of the Sign In With Apple button in Arabic looks like the left image on a Pixel 6 Pro phone. Apple rejects apps that look like this because it does not adhere to its design guidelines. The label overlaps with Apple logo and the phrase is different than Apple's translation. This PR is a simple fix to issue and the result can be seen below.

Before After
Screenshot_20240127_200930 Screenshot_20240127_203025
Apple Design Guidelines
Screenshot_20240127_203026

Related Issues

None.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

russellwheatley commented 5 months ago

Hey @MahMoos - if you merge this branch with the latest on main branch, we can get this PR merged. Thanks!