firebase / FirebaseUI-Flutter

Apache License 2.0
91 stars 79 forks source link

fix(ui_localizations): Update missing generated translations for Romanian language #276

Closed viceamarian closed 5 months ago

viceamarian commented 5 months ago

Description

Added missing generated translation file from src/lang folder for Romanian language.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

viceamarian commented 5 months ago

This is a fix for this PR that contained changes int the arb file only: https://github.com/firebase/FirebaseUI-Flutter/pull/219

russellwheatley commented 5 months ago

Hey @viceamarian - did you update the arb file and run the command to generate the code? See documentation here: https://github.com/firebase/FirebaseUI-Flutter/blob/main/packages/firebase_ui_localizations/README.md#adding-a-new-language

Also - are you able to confirm the translation is correct by a fellow Romanian speaking developer approving the PR? Thanks!

viceamarian commented 5 months ago

Hello @russellwheatley. The code was generated by running dart run firebase_ui_localizations:gen_l10n command. The arb files where previously updated and merged and the translation was approved by another Romanian speaker in this previous PR from December 20th: https://github.com/firebase/FirebaseUI-Flutter/pull/219/files