firebase / FirebaseUI-Flutter

Apache License 2.0
91 stars 79 forks source link

fix(ui_localizations): In the Japanese file, change "login" to "sign and improve translations #304

Closed ywake closed 3 months ago

ywake commented 3 months ago

Description

  • 日本語翻訳ファイルにおいて、「ログイン」と「サインイン」が混在しているので、英語版に合わせて「サインイン」に統一しました。
    • 「ログイン」と「サインイン」のどちらを使うべきかには議論があるかもしれませんが、英語版に合わせることにしました。
  • 日本語の不自然な空白を削除しました。

Related Issues

none

Checklist

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

russellwheatley commented 3 months ago

Hey @ywake - is it possible you could get another developer fluent in Japanese to review this PR, please? I don't speak Japanese I'm afraid, but I am happy to get this PR merged providing it is an improvement 😄

ywake commented 3 months ago

@KoheiKanagu @keigomichi Hello, friends. I saw you in a past pull request, so I was wondering if you could review my pull request?

ywake commented 3 months ago

@russellwheatley I received a review 😄

russellwheatley commented 3 months ago

Thanks @KoheiKanagu & @ywake 🙏