firebase / FirebaseUI-Flutter

Apache License 2.0
107 stars 99 forks source link

fix(firebase_ui_auth): Use widget.email in ForgotPasswordScreen #331

Closed kzrnm closed 6 months ago

kzrnm commented 6 months ago

Description

When EmailForm calls showForgotPasswordScreen, the email address entered in EmailInput is used as the default value. However, if EmailForm has email as field, an empty string will be used as the default value.

I have not written a test yet because of the difficulty in creating a mock showForgotPasswordScreen. Is there a good way to do this?

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

russellwheatley commented 6 months ago

Thanks for the PR! I made some modifications and it has already been merged: https://github.com/firebase/FirebaseUI-Flutter/pull/336