previously the wrong navigator was popped when cancelling or confirming the dialog. this resulted in the dialog still beeing visible and the navigator behind it beeing popped. the fix adds the context object to the function parameter, so the right navigator gets popped.
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.
[X] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[X] All existing and new tests are passing.
[ ] I updated/added relevant documentation (doc comments with ///).
[X] The analyzer (melos run analyze) does not report any problems on my PR.
[X] All unit tests pass (melos run test:unit:all doesn't fail).
Description
previously the wrong navigator was popped when cancelling or confirming the dialog. this resulted in the dialog still beeing visible and the navigator behind it beeing popped. the fix adds the context object to the function parameter, so the right navigator gets popped.
Related Issues
fixes https://github.com/firebase/FirebaseUI-Flutter/issues/212
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process. Updating thepubspec.yaml
and changelogs is not required.///
).melos run analyze
) does not report any problems on my PR.melos run test:unit:all
doesn't fail).Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?