firebase / FirebaseUI-Flutter

Apache License 2.0
109 stars 101 forks source link

🐛 Running web with wasm - The google_sign_in plugin signIn method is deprecated on the web, and will be removed in Q2 2024 #427

Open atreeon opened 1 week ago

atreeon commented 1 week ago

Is there an existing issue for this?

What plugin is this bug for?

Firebase UI Auth

What platform(s) does this bug affect?

Web

List of dependencies used.

flutter pub deps -s list
  Dart SDK 3.5.4
  Flutter SDK 3.24.4
  firebase_core: ^3.6.0
  firebase_auth: ^5.3.1
  firebase_ui_auth: ^1.16.0
  firebase_crashlytics: ^4.1.3
  google_sign_in: ^6.2.1
  firebase_ui_oauth_google: ^1.4.0
  firebase_ui_localizations: ^1.13.0

Steps to reproduce

flutter run web --wasm -d chrome press login button

Expected Behavior

Should login without error

Actual Behavior

Error message: The google_sign_in plugin signIn method is deprecated on the web, and will be removed in Q2 2024. Please use renderButton instead

Additional Information

No response

russellwheatley commented 4 days ago

I don't think we have to worry about this as we don't use google_sign_in plugin for authenticating on the web, we use the firebase_auth plugin signInWithPopup() API: https://github.com/firebase/FirebaseUI-Flutter/blob/main/packages/firebase_ui_oauth/lib/src/platform_oauth_sign_in_web.dart#L22-L34

Not entirely sure how you compiled with wasm either as I ran into a lot of compilation exceptions.