firebase / FirebaseUI-Flutter

Apache License 2.0
99 stars 86 forks source link

🐛 firebase_ui_auth EmailVerificationScreen doesn't have some label Localizations #47

Closed DiegoFelipeOrozco closed 11 months ago

DiegoFelipeOrozco commented 1 year ago

Bug report

I don't find a way to change the main labels of EmailVerificationScreen, it seems to be literals in the source code

Steps to reproduce

Steps to reproduce the behavior:

  1. Go to packages/firebase_ui_auth/lib/src/screens/email_verification_screen.dart:167 and look it by yourself
  2. extending DefaultLocalizations (from packages/firebase_ui_localizations/lib/src/default_localizations.dart) to customize the labels, does not seem to have properties assigned to these labels

Expected behavior

as a result the screen build normally with labels on english...as the others screens, i should be allowed to change the labels to put them in other language(Spanish)

information not provided ### Sample project Providing a minimal example project which demonstrates the bug in isolation from your main App _greatly_ enhances the chance of a timely fix. Please link to the public repository URL. --- ## Additional context Add any other context about the problem here. --- ### Flutter doctor Run `flutter doctor` and paste the output below:
Click To Expand ``` PASTE OUTPUT INSIDE HERE ```
---

Flutter dependencies

Click To Expand ``` Dart SDK 2.18.5 Flutter SDK 3.3.9 inndoc 1.0.0+1 dependencies: - cloud_firestore 4.2.0 [cloud_firestore_platform_interface cloud_firestore_web collection firebase_core firebase_core_platform_interface flutter meta] - cupertino_icons 1.0.3 - firebase_auth 4.2.1 [firebase_auth_platform_interface firebase_auth_web firebase_core firebase_core_platform_interface flutter meta] - firebase_core 2.4.0 [firebase_core_platform_interface firebase_core_web flutter meta] - firebase_messaging 14.1.4 [firebase_core firebase_core_platform_interface firebase_messaging_platform_interface firebase_messaging_web flutter meta] - firebase_ui_auth 1.1.3 [email_validator firebase_auth firebase_core firebase_dynamic_links firebase_ui_localizations firebase_ui_oauth flutter flutter _localizations flutter_svg] - flutter 0.0.0 [characters collection material_color_utilities meta vector_math sky_engine] - geolocator 9.0.2 [flutter geolocator_platform_interface geolocator_android geolocator_apple geolocator_web geolocator_windows] - google_maps_flutter 2.1.3 [flutter flutter_plugin_android_lifecycle google_maps_flutter_platform_interface] - google_maps_flutter_web 0.4.0+3 [flutter flutter_web_plugins google_maps google_maps_flutter_platform_interface sanitize_html stream_transform] - http 0.13.3 [async http_parser meta path pedantic] - provider 6.0.5 [collection flutter nested] - url_launcher 6.0.10 [flutter meta url_launcher_linux url_launcher_macos url_launcher_platform_interface url_launcher_web url_launcher_windows] dev dependencies: - flutter_test 0.0.0 [flutter test_api path fake_async clock stack_trace vector_math async boolean_selector characters collection matcher material_color _utilities meta source_span stream_channel string_scanner term_glyph] transitive dependencies: - _flutterfire_internals 1.0.10 [cloud_firestore_platform_interface cloud_firestore_web collection firebase_core firebase_core_platform_interface flutte r meta] - async 2.9.0 [collection meta] - boolean_selector 2.1.0 [source_span string_scanner] - characters 1.2.1 - charcode 1.3.1 - clock 1.1.1 - cloud_firestore_platform_interface 5.9.2 [_flutterfire_internals collection firebase_core flutter meta plugin_platform_interface] - cloud_firestore_web 3.1.1 [_flutterfire_internals cloud_firestore_platform_interface collection firebase_core firebase_core_web flutter flutter_web_pl ugins js] - collection 1.16.0 - crypto 3.0.2 [typed_data] - csslib 0.17.1 [source_span] - desktop_webview_auth 0.0.11 [crypto flutter http flutter_web_plugins plugin_platform_interface] - email_validator 2.1.17 - fake_async 1.3.1 [clock collection] - firebase_auth_platform_interface 6.11.5 [_flutterfire_internals collection firebase_core flutter meta plugin_platform_interface] - firebase_auth_web 5.2.1 [firebase_auth_platform_interface firebase_core firebase_core_web flutter flutter_web_plugins http_parser intl js meta] - firebase_core_platform_interface 4.5.2 [collection flutter flutter_test meta plugin_platform_interface] - firebase_core_web 2.0.2 [firebase_core_platform_interface flutter flutter_web_plugins js meta] - firebase_dynamic_links 5.0.9 [firebase_core firebase_core_platform_interface firebase_dynamic_links_platform_interface flutter meta plugin_platform_in terface] - firebase_dynamic_links_platform_interface 0.2.3+24 [_flutterfire_internals firebase_core flutter meta plugin_platform_interface] - firebase_messaging_platform_interface 4.2.8 [_flutterfire_internals firebase_core flutter meta plugin_platform_interface] - firebase_messaging_web 3.2.9 [_flutterfire_internals firebase_core firebase_core_web firebase_messaging_platform_interface flutter flutter_web_plugins js meta] - firebase_ui_localizations 1.0.1 [flutter flutter_localizations intl path] - firebase_ui_oauth 1.1.3 [desktop_webview_auth firebase_auth firebase_ui_auth flutter_svg flutter] - flutter_localizations 0.0.0 [flutter intl characters clock collection material_color_utilities meta path vector_math] - flutter_plugin_android_lifecycle 2.0.5 [flutter] - flutter_svg 1.1.6 [flutter meta path_drawing vector_math xml] - flutter_web_plugins 0.0.0 [flutter js characters collection material_color_utilities meta vector_math] - geolocator_android 4.1.4 [flutter geolocator_platform_interface] - geolocator_apple 2.1.1+1 [flutter geolocator_platform_interface] - geolocator_platform_interface 4.0.4 [flutter plugin_platform_interface vector_math meta] - geolocator_web 2.1.4 [flutter flutter_web_plugins geolocator_platform_interface] - geolocator_windows 0.1.0 [flutter geolocator_platform_interface] - google_maps 6.2.0 [js_wrapping meta] - google_maps_flutter_platform_interface 2.2.4 [collection flutter plugin_platform_interface stream_transform] - html 0.15.0 [csslib source_span] - http_parser 4.0.0 [charcode collection source_span string_scanner typed_data] - intl 0.17.0 [clock path] - js 0.6.4 - js_wrapping 0.7.4 [js] - matcher 0.12.12 [stack_trace] - material_color_utilities 0.1.5 - meta 1.8.0 - nested 1.0.0 [flutter] - path 1.8.2 - path_drawing 1.0.1 [vector_math meta path_parsing flutter] - path_parsing 1.0.1 [vector_math meta] - pedantic 1.11.1 - petitparser 5.1.0 [meta] - plugin_platform_interface 2.1.3 [meta] - sanitize_html 2.0.0 [html meta] - sky_engine 0.0.99 - source_span 1.9.0 [collection path term_glyph] - stack_trace 1.10.0 [path] - stream_channel 2.1.0 [async] - stream_transform 2.0.0 - string_scanner 1.1.1 [source_span] - term_glyph 1.2.1 - test_api 0.4.12 [async boolean_selector collection meta source_span stack_trace stream_channel string_scanner term_glyph matcher] - typed_data 1.3.0 [collection] - url_launcher_linux 2.0.2 [flutter] - url_launcher_macos 2.0.2 [flutter] - url_launcher_platform_interface 2.0.4 [flutter plugin_platform_interface] - url_launcher_web 2.0.4 [flutter flutter_web_plugins meta url_launcher_platform_interface] - url_launcher_windows 2.0.2 [flutter] - vector_math 2.1.2 - xml 6.1.0 [collection meta petitparser] ```

thanks for the effort and greetings from Colombia

darshankawar commented 1 year ago

Thanks for the report. Keeping this issue open for team's attention and insights on expected behavior.

darshankawar commented 1 year ago

/cc @lesnitsky

JulianWijst commented 1 year ago

Is there an update from the team about this issue or an ETA? Because I'm not sure about the maintenance of this package.