search

firebase / FirebaseUI-Flutter

Apache License 2.0
101 stars 91 forks source link

🐛 [flutterfire_ui] Missing localization in profile_screen #54

Closed przemek-lagan closed 1 year ago

przemek-lagan commented 2 years ago

Bug report

There are six hardcoded messages in english in profile_screen, concerning verification e-mail. It is impossible to override them when making localization, that is not supported yet.

Steps to reproduce

Go to ProfileScreen with unverified account and locale other than English. Look in profile_screen.dart for 'Email is not verified' strings etc.

Expected behavior

Strings should be replaced with labels (l.variablename).

Sample project

I've corrected the strings in my fork of flutterfire, but my solution lacks translations for supported languages. Also, that could be a breaking change, as the labels are required, depending of localization method used.

darshankawar commented 2 years ago

Thanks for the report @przemek-lagan I think there was an active PR to add localization https://github.com/firebase/flutterfire/pull/8366/files but seem to have been closed. You may keep an eye on it if it gets reopened.

I'll label this issue for now.

SCarcalicea commented 1 year ago

Hey, are there any news about this change happening any time soon? I could address it based on the previous PR but I cannot push any changes :)