firebase / FirebaseUI-Flutter

Apache License 2.0
99 stars 86 forks source link

fix: update ru translations to remove English duplicates #65

Closed opimand closed 1 year ago

opimand commented 1 year ago

Description

Elimination of duplicates in the Russian dictionary: removal of repetitive English words has been performed, as they are unnecessary for functionality. Due to these duplicates, elements of the user interface appear overloaded, often resulting in overflow.

Screenshot 2023-08-21 at 17 34 09

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

opimand commented 1 year ago

Please update relevant .arb file and generate dart class from cli as mention in the contributing section of the docs

I tried to run run dart run firebase_ui_localizations:gen_l10n as mentioned in the docs, but got an error every time

firebase_ui_localizations % flutter run firebase_ui_localizations:gen_l10n
Target file "firebase_ui_localizations:gen_l10n" not found.

May be I missunderstood something? I tried to do that at different directories, all posible I guess
Thats why I just generete .arb file by Android Studiio

lesnitsky commented 1 year ago
cd packages/firebase_ui_localizations
dart run firebase_ui_localizations:gen_l10n
#^^^
# dart, not flutter
opimand commented 1 year ago
cd packages/firebase_ui_localizations
dart run firebase_ui_localizations:gen_l10n
#^^^
# dart, not flutter
firebase_ui_localizations % dart run firebase_ui_localizations:gen_l10n
Resolving dependencies in /Users/opimand/Documents/dev/FirebaseUI-Flutter/packages/firebase_ui_localizations... 
Because firebase_ui_localizations requires the Flutter SDK, version solving failed.

Flutter users should run `flutter pub get` instead of `dart pub get`.
lesnitsky commented 1 year ago

what does dart --version show for you? I suspect you have a flutter installation and a separate dart installation which is outdated, but that's just a wild guess.

opimand commented 1 year ago

art --version

 firebase_ui_localizations % dart --version
Dart SDK version: 3.0.7 (stable) (Mon Jul 24 13:17:56 2023 +0000) on "macos_arm64"

Works as usual...