Closed MaximeRougieux closed 11 months ago
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
Hey @lesnitsky, thanks for your quick review! I pushed the test as asked.
Btw, sorry for the small detailed PR, I opened it in a rush. If you need more details on this, please feel free to ask 🙂
@MaximeRougieux could you please run melos run add-license-header
?
@lesnitsky done!
LGTM!
Description
This change is needed to rebuild the footer when the action changes (for example when the user click on the header auth action switch)
Related Issues
None
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process. Updating thepubspec.yaml
and changelogs is not required.///
).melos run analyze
) does not report any problems on my PR.melos run test:unit:all
doesn't fail).Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?