firebase / FirebaseUI-Flutter

Apache License 2.0
99 stars 86 forks source link

fix(ui_auth): Pass correct AuthAction to the footerBuilder #70

Closed MaximeRougieux closed 11 months ago

MaximeRougieux commented 1 year ago

Description

This change is needed to rebuild the footer when the action changes (for example when the user click on the header auth action switch)

Related Issues

None

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

MaximeRougieux commented 1 year ago

Hey @lesnitsky, thanks for your quick review! I pushed the test as asked.

Btw, sorry for the small detailed PR, I opened it in a rush. If you need more details on this, please feel free to ask 🙂

lesnitsky commented 12 months ago

@MaximeRougieux could you please run melos run add-license-header?

MaximeRougieux commented 12 months ago

@lesnitsky done!

lesnitsky commented 12 months ago

LGTM!