feat(ui_firestore): implemented separators and fetching indicator

ShahoodulHassan commented 1 year ago

Added the following features to FirestoreListView:

show separators between list items
show fetching indicator when the list reaches the end
show both fetching indicator and separators

Description

Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[ ] All existing and new tests are passing.
[x] I updated/added relevant documentation (doc comments with ///).
[ ] The analyzer (melos run analyze) does not report any problems on my PR.
[ ] All unit tests pass (melos run test:unit:all doesn't fail).
[x] I read and followed the Flutter Style Guide.
[x] I signed the CLA.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change.
[x] No, this is not a breaking change.

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

lesnitsky commented 1 year ago

format action is failing because new files are generated during melos bootstrap, this was fixed on the main branch, please rebase the latest main to get format green.

ShahoodulHassan commented 12 months ago

format action is failing because new files are generated during melos bootstrap, this was fixed on the main branch, please rebase the latest main to get format green.

As a first step, I tried to update the main branch in my fork (using Sync Fork) but I ended up with many errors that I was unable to fix. Is there any other way to achieve this?

lesnitsky commented 12 months ago

add an origin to your local git checkout: git remote add upstream git@github.com:firebase/FirebaseUI-Flutter.git
git checkout main
git pull upstream main (syncs the latest main branch of this repo with your fork)
git checkout <your-branch>
git merge main
resolve merge conflicts, if any
commit and push

ShahoodulHassan commented 12 months ago

add an origin to your local git checkout: git remote add upstream git@github.com:firebase/FirebaseUI-Flutter.git

git checkout main

git pull upstream main (syncs the latest main branch of this repo with your fork)

git checkout <your-branch>

git merge main

resolve merge conflicts, if any

commit and push

After performing step 3, I get to the same stage where I was using 'Sync fork'. There are errors in packages/firebase_ui_auth and tests/integration_test that I can't happen to fix. Please let me know how to work around it.

lesnitsky commented 12 months ago

There are errors in packages/firebase_ui_auth and tests/integration_test that I can't happen to fix.

What errors exactly are you getting?

lesnitsky commented 11 months ago

@ShahoodulHassan will you be able to address PR review feedback?

ShahoodulHassan commented 11 months ago

Sure I'll provide the feedback on errors by tomorrow max. Thanks for your patience!

ShahoodulHassan commented 11 months ago

There are errors in packages/firebase_ui_auth and tests/integration_test that I can't happen to fix.

What errors exactly are you getting?

I checked again today and the errors are all gone.

ShahoodulHassan commented 10 months ago

@lesnitsky I've incorporated all requested changes via this commit. Kindly review these and provide your valuable feedback!

lesnitsky commented 10 months ago

Please resolve conflicts

ShahoodulHassan commented 10 months ago

Please resolve conflicts

Done!

ShahoodulHassan commented 10 months ago

See this comment

I've submitted reply to this comment and also resolved the conflicts. Now waiting for your further feedback plz....!

ShahoodulHassan commented 10 months ago

@lesnitsky What should I do in order to pass all the failing checks?

lesnitsky commented 10 months ago

@ShahoodulHassan I'm taking care of those, no action required from your side.

ShahoodulHassan commented 9 months ago

@ShahoodulHassan I'm taking care of those, no action required from your side.

Is it gonna take more time for merging this into the main branch?

firebase / FirebaseUI-Flutter