firebase / FirebaseUI-iOS

iOS UI bindings for Firebase.
Apache License 2.0
1.51k stars 474 forks source link

Still having issues with GTMSessionFetcher downgrading to version 2.3.0 from 3.1.0 #1138

Closed ian-sayles closed 1 year ago

ian-sayles commented 1 year ago

Welcome to FirebaseUI and thanks for submitting an issue!

Please take a look at open issues, as well as resolved issues, to see if your issue is either already being addressed, or has been solved by someone else.

If your issue concerns the CocoaPods error, "...transitive dependencies that include static binaries", please take a look at any of the following issues and see if your problem is solved: #48, #47, #46, #34, #23.

If not, please feel free to fill in the following info so we can help faster!

Step 1: Are you in the right place?

Step 2: Describe your environment

Step 3: Describe the problem:

When adding FirebaseUI-IOS to my project it changes the GTMSessionFetcher version from 3.1.0 to 2.3.0

I raised this issue a few months ago, and was supposedly fixed with in 1134, see below

https://github.com/firebase/FirebaseUI-iOS/issues/1125 https://github.com/firebase/FirebaseUI-iOS/pull/1134

Steps to reproduce:

Before:

Screenshot 2023-03-17 at 12 08 38

After adding FiirebaseUi

Screenshot 2023-03-17 at 12 23 49

This is the packages:

Screenshot 2023-03-17 at 12 26 47

Not sure why it keeps changing GTMSessionFetcher back to older version that is not supported by the latest Firebase SDK, can anyone point me into what I'm doing wrong?

Observed Results:

N/A

Expected Results:

N/A

Relevant Code:

N/A

morganchen12 commented 1 year ago

Sorry about that. The fix should be released now.

ian-sayles commented 1 year ago

Thanks for taking the time to do the upgrade, but it still downgrades when I install FirebaseUI version 13.

morganchen12 commented 1 year ago

Can you share the versions screenshot again? We removed GTMSessionFetcher entirely from the FirebaseUI package, so it's most likely some other dependency.

ian-sayles commented 1 year ago

I created a new project and added Firebase SDK then added FirebaseUI, and checked all the additional dependency that was added and GoogleSignIn uses GTMSessionFetcher.

.package( name: "GTMSessionFetcher", url: "https://github.com/google/gtm-session-fetcher.git", "1.5.0" ..< "3.0.0"),

Firebase SDK ONLY:

New Project 1

Add FirebaseUI

New Project 3

What I selected when I installed:

New Project 2
paulb777 commented 1 year ago

GoogleSignIn 7.0.0 supports GTMSessionFetcher 3.x. See https://github.com/google/GoogleSignIn-iOS/blob/main/GoogleSignIn.podspec#L37

ian-sayles commented 1 year ago

Thanks Paul for link.

Next time a new version of FirebaseUI-IOS is released can it use GoogleSignIn version 7 ?