[Phone Auth] Building with Xcode 14.3.X, displays wrong country code

[zrn-ns]

Welcome to FirebaseUI and thanks for submitting an issue!

Please take a look at open issues, as well as resolved issues, to see if your issue is either already being addressed, or has been solved by someone else.

If your issue concerns the CocoaPods error, "...transitive dependencies that include static binaries", please take a look at any of the following issues and see if your problem is solved: #48, #47, #46, #34, #23.

If not, please feel free to fill in the following info so we can help faster!

Step 1: Are you in the right place?

• For issues or feature requests related to the code in this repository file a GitHub issue.
• For general technical questions, post a question on StackOverflow tagged appropriately.
• For general Firebase discussion, use the firebase-talk google group
• For help troubleshooting your application that does not fall under one of the above categories, reach out to the personalized Firebase support channel

Step 2: Describe your environment

• Objective C or Swift: Swift
• iOS version: iOS16.5.1
• Firebase SDK version: 10.12.0
• FirebaseUI version: 13.0.0
• CocoaPods Version: 1.12.1

Step 3: Describe the problem:

First of all, I would like to thank you for developing this wonderful framework.

Steps to reproduce:

1. Implement sign-in with phone number feature with FirebaseUI-Auth.
2. Build application with Xcode 14.3.X .
3. Run application on iPhone sold in countries other than the United States.

Observed Results:

• The default country code displayed at phone number login is fixed to U.S. (+1)

Expected Results:

• The default country code should be decided by the carrier of device. (ex: +81)

Using Xcode 14.2, This problem does not occur and the default country code is decided by the carrier of device.

Relevant Code:

Other Info

First of all, it seems that you can get a country code (like as +1, +81) by accessing CTCarrier.isoCountryCode of CoreTelephony, but this API was deprecated in iOS16, and from 16.4, a fixed value is returned.

https://developer.apple.com/forums/thread/714876

iOS 16 CTCarrier deprecation Core Telephony Deprecations CTCarrier, a deprecated API, returns static values for apps that are built with the iOS 16.4 SDK or later.

I found that the process to get the default country code (FUICountryCodes.m#127) accesses CTCarrier.isoCountryCode, so this is likely the cause.

https://github.com/firebase/FirebaseUI-iOS/blob/4dad85472124ce78aca8d20e6a2c8658357e1d2e/FirebasePhoneAuthUI/Sources/FUICountryCodes.m#L127

The standard iOS API has been discontinued and may be difficult to fix this problem, but I would appreciate it if you could fix it.

Best regards.

[zrn-ns]

If it is difficult to obtain a default country code, another option is to allow developers to set an arbitrary country code as default.

[morganchen12]

Hi @zrn-ns, would something like this be suitable? https://github.com/firebase/FirebaseUI-iOS/pull/1159

[zrn-ns]

@morganchen12 Thank you for implementing!

It needs to be fixed in that setting a code like "JP" to defaultCountryCode causes a crash, but the way you implemented it is exactly what I was looking for.

[morganchen12]

Fixed the crash. This API will be released today.

[zrn-ns]

@morganchen12 Thank you! 🎉 🎉 🎉