firebase / FirebaseUI-iOS

iOS UI bindings for Firebase.
Apache License 2.0
1.51k stars 475 forks source link

Module 'FirebaseAuth' not found #1196

Closed joaomvfsantos closed 2 months ago

joaomvfsantos commented 2 months ago

After updating to firebase 11.0.0 and firebase-ui 14.2.0 it's not possible to build the project with the error: Module 'FirebaseAuth' not found

Xcode 15.4 macOS 14.6.1 (Sonoma) Using Swift Package Manager

Screenshot 2024-08-12 at 11 32 26 Screenshot 2024-08-12 at 11 32 38

Example project where the issue happens: https://github.com/joaomvfsantos/FirebaseUITest

JoniGoos commented 2 months ago

I have the same issue

paulb777 commented 2 months ago

I'm not able to reproduce. I don't see any Swift Packages in the "Example Project". When I add FirebaseUI to it with the specified targets, it builds fine.

Please share a reproducible example.

joaomvfsantos commented 2 months ago

@paulb777 Thanks for checking. There was a commit missing in the example repository, which I apolagize. Please check again if possible.

paulb777 commented 2 months ago

@joaomvfsantos Thanks! I've reproduced and will investigate a fix.

paulb777 commented 2 months ago

Thanks for reporting and sharing the repro. The 14.2.1 release should fix the build issue.

joaomvfsantos commented 2 months ago

@paulb777 Thanks for the fix. Just as fyi, this change means we need to also import FirebaseAuth in places where before we only needed to import FirebaseAuthUI (if we reference classes from FirebaseAuth). That's fine for me, but for example the sample code does not compile anymore because of this, and should be updated.

paulb777 commented 2 months ago

We updated the Firestore quickstart. Are you seeing it in other sample code?

joaomvfsantos commented 2 months ago

@paulb777 I was talking specifically about the sample project in the FirebaseUI-iOS/samples folder.

paulb777 commented 2 months ago

@joaomvfsantos Thanks for pointing that out. I fixed a few issues with the Swift sample build in #1202.