search

firebase / FirebaseUI-iOS

iOS UI bindings for Firebase.
Apache License 2.0
1.51k stars 475 forks source link

Terms of Service and Privacy Policy UI bugs #645

Closed AndrewGable closed 5 years ago

AndrewGable commented 5 years ago

Describe your environment

Step 3: Describe the problem:

Terms of service and privacy policy cut off in safe area: IMG_0681

Terms of Service and Privacy policy not centered: IMG_0682

Steps to reproduce:

  1. Set terms of service and privacy policy:
let kFirebaseTermsOfService = URL(string: "https://example.com/TermsOfService.html")!
authUI?.tosurl = kFirebaseTermsOfService
let kFirebasePrivacyPolicy = URL(string: "https://example.com/PrivacyPolicy.html")!
authUI?.privacyPolicyURL = kFirebasePrivacyPolicy
  1. Start login with email
  2. Enter existing user
  3. See bug 2

Expected Results:

I would expect the terms of service to be centered when applicable and/or follow safe area conventions.

Relevant Code:

let kFirebaseTermsOfService = URL(string: "https://example.com/TermsOfService.html")!
authUI?.tosurl = kFirebaseTermsOfService
let kFirebasePrivacyPolicy = URL(string: "https://example.com/PrivacyPolicy.html")!
authUI?.privacyPolicyURL = kFirebasePrivacyPolicy
renkelvin commented 5 years ago

1st issue fixed. As for the 2nd issue, it has to be left right aligned due to legal issue.

AndrewGable commented 5 years ago

@renkelvin - Awesome, thanks for the fix on the first bug! 🎉

Sorry if I wasn't super clear on the second bug, but I think the By Continuing... text should have a bit of vertical padding from the safe area as it's hard for the user to tap Privacy Policy button as the iPhone X home button thinks it's being tapped. I think moving it "up" vertically a bit would make the Privacy Policy button easier to tap. Thanks as always for your hard work!

renkelvin commented 5 years ago

Yeah, that is fixed. The text in the second bug has to be right aligned.

AndrewGable commented 5 years ago

Gotcha, thanks again for the fix!

romrell4 commented 1 year ago

Could I get some additional clarification on what the legal ramifications of centering the ToS / Privacy Policy links? It looks pretty tacky for our users, and before I try and rip our all of the super helpful AuthUI features that we're getting by using this library, I'd love to see if there's a way this could be addressed still :)