search

firebase / extensions

Source code for official Firebase extensions
https://firebase.google.com/products/extensions
Apache License 2.0
885 stars 377 forks source link

Remove dev dependencies from dependencies list #1565

Open cabljac opened 1 year ago

cabljac commented 1 year ago

Several extensions have things like jest and @types/... packages in their dependencies.

These should be moved to devDependencies.

In the past the reason for @types/... being in dependencies was because it needed to be for the build step of the extension. I'm not sure what the situation is now.

This should be checked across all 4 official repositories.

dackers86 commented 1 year ago

As the build processes uses docker, can we make sure this works as expected on install. Typically, in the past some dependencies will causes errors as the module cannot be found.