Closed gmogames closed 2 years ago
rachaprince
commented
2 years ago Hey @gmogames! Apologies for the delayed response.
Right now, I think the best workaround is use the app parameter to specify the app id instead of the googleservice_info_plist_path. I'll raise your request to be able to pass the full path of the .app or the actual plist file to the team.
Thanks!
rachaprince
commented
2 years ago I'm going to close this issue for now, but please fill out a Firebase feature request (https://firebase.google.com/support/troubleshooter/report/features) if you are still interested in this functionality!
vassily-fr
commented
5 months ago Hi, I came up with a simple solution using other Fastlane command line :
appID = get_info_plist_value(path: "./#{GEN_DIR}/../MyApplication/Configuration/GoogleService-Info.plist", key: "GOOGLE_APP_ID")
ipa_file_name = "#{file_name}.ipa"
dsym_file_name = "#{file_name}.app.dSYM.zip"
appID = get_info_plist_value(path: "./#{GEN_DIR}/../MyApplication/Configuration/GoogleService-Info.plist", key: "GOOGLE_APP_ID")
release = firebase_app_distribution(
app: "#{appID}",
testers: "truc@truc.com",
release_notes: "#{RELEASE_NOTE_CONTENT}",
ipa_path: "./#{GEN_DIR}/#{ipa_file_name}"
)
upload_symbols_to_crashlytics(dsym_path: "./#{GEN_DIR}/#{dsym_file_name}", gsp_path: "./#{GEN_DIR}/../MyApplication/Configuration/GoogleService-Info.plist", binary_path: "./#{GEN_DIR}/../Pods/FirebaseCrashlytics/upload-symbols")
Issue Description
I cannot get googleservice_info_plist_path to work when using firebase_app_distribution on it's own lane. I have lanes for provisioning, building and deploying separate and they are called at different times, thus not having a shared lane value for the Xcode archive location, so it doesn't matter what value I put into the plist path, the plugin will always fail to get the app id as it uses the shared lane values to get the archived path, and in my case it's always null.
Would be awesome if we could just pass the full path of the .app or for the actual plist file without depending on the archive path being there.
Configuration
Complete verbose output
Verbose Output
gmo@A0792-MS-GM app_dir % bundle exec fastlane deploy to:enterprise ipa:./build/app_staging.ipa [✔] 🚀 +-------------------------------------------+---------+-----------------------------------------------------------+ | Used plugins | +-------------------------------------------+---------+-----------------------------------------------------------+ | Plugin | Version | Action | +-------------------------------------------+---------+-----------------------------------------------------------+ | fastlane-plugin-aws_s3 | 2.0.2 | aws_s3 | | fastlane-plugin-xcconfig_actions | 1.4.2 | build_settings_to_flags, read_xcconfig, validate_xcconfig | | fastlane-plugin-xcconfig | 2.0.0 | update_xcconfig_value, set_xcconfig_value, | | | | get_xcconfig_value | | fastlane-plugin-firebase_app_distribution | 0.2.9 | firebase_app_distribution_login, | | | | firebase_app_distribution_get_udids, | | | | firebase_app_distribution | +-------------------------------------------+---------+-----------------------------------------------------------+ [19:15:45]: ------------------------------ [19:15:45]: --- Step: default_platform --- [19:15:45]: ------------------------------ [19:15:45]: Driving the lane 'ios deploy' 🚀 [19:15:45]: ----------------------------- [19:15:45]: --- Step: setup_circle_ci --- [19:15:45]: ----------------------------- [19:15:45]: Not running on CI, skipping CI setup [19:15:45]: ipa: ./build/app_staging.ipa [19:15:45]: dsym: output/gym/app_staging.app.dSYM.zip [19:15:45]: --------------------------------------------------- [19:15:45]: --- Step: Switch to ios deploy_to_firebase lane --- [19:15:45]: --------------------------------------------------- [19:15:45]: Cruising over to lane 'ios deploy_to_firebase' 🚖 [19:15:45]: path: <<<<<<< path empty as SharedValues::XCODEBUILD_ARCHIVE is not present [19:15:45]: --------------------------------------- [19:15:45]: --- Step: firebase_app_distribution --- [19:15:45]: --------------------------------------- [19:15:45]: ------------------- [19:15:45]: --- Step: is_ci --- [19:15:45]: ------------------- +------------------+------------+ | Lane Context | +------------------+------------+ | DEFAULT_PLATFORM | ios | | PLATFORM_NAME | ios | | LANE_NAME | ios deploy | +------------------+------------+ [19:15:45]: Missing app id. Please check that the app parameter is set and try again +------+---------------------------------------+-------------+ | fastlane summary | +------+---------------------------------------+-------------+ | Step | Action | Time (in s) | +------+---------------------------------------+-------------+ | 1 | default_platform | 0 | | 2 | setup_circle_ci | 0 | | 3 | Switch to ios deploy_to_firebase lane | 0 | | 💥 | firebase_app_distribution | 0 | | 5 | is_ci | 0 | +------+---------------------------------------+-------------+ [19:15:45]: fastlane finished with errors Looking for related GitHub issues on fastlane/fastlane... ➡️ DELIVER (2.150.0.rc3/4) always ask attribute whatsNew https://github.com/fastlane/fastlane/issues/16700 [open] 91 💬 a day ago ➡️ [iTunes Transporter]: Read Timed Out - unable to upload app to TestFlight https://github.com/fastlane/fastlane/issues/16892 [open] 60 💬 2 days ago ➡️ Fastlane produce fails with error, but appears to still create the app on App Store Connect https://github.com/fastlane/fastlane/issues/18794 [closed] 8 💬 5 weeks ago and 117 more at: https://github.com/fastlane/fastlane/search?q=Missing%20app%20id.%20Please%20check%20that%20the%20app%20parameter%20is%20set%20and%20try%20again&type=Issues&utf8=✓ 🔗 You can ⌘ + double-click on links to open them directly in your browser. Traceback (most recent call last): 36: from /Users/gmo/Apps/app_dir/vendor/bundle/ruby/2.7.0/bin/ruby_executable_hooks:22:in `Environment