search

firebase / fastlane-plugin-firebase_app_distribution

fastlane plugin for Firebase App Distribution. https://firebase.google.com/docs/app-distribution
MIT License
166 stars 27 forks source link

env_name for service_credentials_file = GOOGLE_APPLICATION_CREDENTIALS #373

Closed Fl0p closed 1 month ago

Fl0p commented 1 month ago

https://github.com/firebase/fastlane-plugin-firebase_app_distribution/blob/4bc7839cf44564d327fcebf82553b687f18140ca/lib/fastlane/plugin/firebase_app_distribution/actions/firebase_app_distribution_action.rb#L568-L571

evn_name should be "GOOGLE_APPLICATION_CREDENTIALS"

e.g.

 FastlaneCore::ConfigItem.new(key: :service_credentials_file, 
                              env_name: "GOOGLE_APPLICATION_CREDENTIALS",
                              description: "Path to Google service account json file", 
                              optional: true, 
                              type: String),

according to the doc https://firebase.google.com/docs/app-distribution/ios/distribute-fastlane#service-acc-fastlane

lfkellogg commented 1 month ago

That environment variable is actually handled by the Google Auth library, not our plugin: https://github.com/firebase/fastlane-plugin-firebase_app_distribution/blob/master/lib/fastlane/plugin/firebase_app_distribution/helper/firebase_app_distribution_auth_client.rb#L60

That's why we don't want to set it to env_name for our service_credentials_file parameter.

If it's not working for you please let us know and include logs, thanks!