change: Update project target frameworks and dependencies

firebase / firebase-admin-dotnet

Firebase Admin .NET SDK

https://firebase.google.com/docs/admin/setup

Apache License 2.0

367 stars 131 forks source link

change: Update project target frameworks and dependencies #251

Closed DenSmoke closed 3 years ago

DenSmoke commented 4 years ago

Project target frameworks replaced with .NET Framework 4.6.1 and .NET Standard 2.0 to be consistent with the frameworks supported by other .NET libraries associated with Google Cloud Platform.
- Removed Google.Api.Gax
- Updated Google.Api.Gax.Rest to 3.2.0
- Updated Google.Apis.Auth to 1.49.0
- Updated System.Collections.Immutable to 1.7.1
- Fixed tests

API CHANGE: Dropped support for netstandard1.5 and net45 target frameworks. Developers are now required to use netstandard2.0 or net461. API CHANGE: Upgraded the dependency Google.Api.Gax to the latest major version. Developers that use the PagedAsyncEnumerable interface from this package (usually as the return value of list iteration API calls), may have to update their implementations accordingly.

Resolves #264 #265 #207

DenSmoke commented 4 years ago

@hiranya911 @lahirumaramba Can someone review please?

hiranya911 commented 4 years ago

@DenSmoke Thanks for the PR. Really appreciate your effort. This contains several breaking changes. Specifically, following changes are breaking:

Dropping support for netstandard1.5
Upgrading from Gax 2.0 to 3.0

We can look into accepting those changes in the next quarter, and releasing v2 of the SDK. Can I ask you to extract the above 2 changes from here into a separate PR? The remaining changes in this PR (e.g. upgrading test dependencies) can be merged immediately.

DenSmoke commented 4 years ago

@hiranya911 Upgrading test dependencies is not critical. Main purpose is to solve conflicts like in issue #207 when using GAX 3.0 dependent Google Cloud .NET libraries and Firebase Admin SDK in same .NET project

hiranya911 commented 4 years ago

Yeah, I understand. We can hold on to this PR for now, and come up with a plan to merge it in the coming months. I just need to sync up with other teams and see if we have any upcoming releases that might potentially conflict with this.

hiranya911 commented 3 years ago

We have slated this for a release in the next quarter (q4 2020). As a first step we will try to add net461 to the list of target frameworks without any additional changes, and release that. Then we can merge this PR on top of that.

hiranya911 commented 3 years ago

@DenSmoke can I ask you to update this PR and sync up with the latest state of the master branch? We can merge this soon after that.

DenSmoke commented 3 years ago

@hiranya911 done