Feature Request: Add support for HTTP/2

firebase / firebase-admin-dotnet

Firebase Admin .NET SDK

https://firebase.google.com/docs/admin/setup

Apache License 2.0

357 stars 129 forks source link

Feature Request: Add support for HTTP/2 #356

Open TommyN opened 11 months ago

TommyN commented 11 months ago

Modifying the FirebaseMessaingClient.SendAsync and adding new Version(2, 0) should allow HTTP/2 to be used.

  ...
  var request = new HttpRequestMessage()
  {
    Version = new Version(2, 0),
    Method = HttpMethod.Post,
    RequestUri = new Uri(this.sendUrl),
    Content = NewtonsoftJsonSerializer.Instance.CreateJsonHttpContent(body),
  };

Users of this library would probably also want to configure the EnableMultipleHttp2Connections property, but as far as I can gather this requires changes in the Google.Apis.Core and requires >= .NET 5

google-oss-bot commented 11 months ago

I found a few problems with this issue:

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
This issue does not seem to follow the issue template. Make sure you provide all the required information.

ewfian commented 11 months ago

JensSchadron commented 1 month ago

@lahirumaramba Any news on this? Because of the deprecation of the FCM batch API endpoint (in 15 days from now) and the HTTP V1 API relying mostly on HTTP/2 multiplexing to achieve greater throughput, this seems like a pretty important thing to look into.