firebase / firebase-admin-dotnet

Firebase Admin .NET SDK
https://firebase.google.com/docs/admin/setup
Apache License 2.0
369 stars 131 forks source link

Unexpected unknown-error is returned #371

Open hankovich opened 9 months ago

hankovich commented 9 months ago

I use SubscribeToTopicAsync method to add tokens to topic and sometimes get errors. Some of them are easy to understand (registration-token-not-registered), but sometimes I see undocumented unknown-error. I do not how to handle it and my background job makes more and more attempts to add such tokens to topic.

I suggest

  1. Make constants like invalid-argument, registration-token-not-registered public. Or (which is event better) at as a simple proxy, do not add any additional error mapping, do not add any layers and abstractions over the fcm api
  2. Do not swallow info about unknown errors for my code to be able to handle them. For now I do not known what to do with such errors. Are they retriable, are they permanent? Who knows
google-oss-bot commented 9 months ago

I found a few problems with this issue: