search

firebase / firebase-admin-dotnet

Firebase Admin .NET SDK
https://firebase.google.com/docs/admin/setup
Apache License 2.0
369 stars 131 forks source link

[FR] Missing MultiFactor property in UserRecord #379

Open cperez87 opened 7 months ago

cperez87 commented 7 months ago

Hi, The MultiFactor property is missing in the .NET (and Java) implementation of UserRecord. Other implementations like Go, Python, and Node already have it.

While we wait for it to be added, is there any recommendation to get the raw response returned by the accounts:lookup call?

Thanks

google-oss-bot commented 7 months ago

I found a few problems with this issue:

cperez87 commented 7 months ago

In the meantime, I ended up creating a custom HttpClientFactory to add a custom DelegatingHandler with a Channel. And subscribe to it to capture the Response content. Any other temporary suggestion is welcome.

Somebodybro commented 3 months ago

Hey! I made a fork for this here and started working on this so i'll make a pr when that is done.

There are some new things I need to do, like adding a list property to userRecordArgs, but that should be fine.

There should not be any other problem in doing this except adding the fields and making them serialize/deserialize correctly.

This is my first time contributing to the firebase .net sdk repo, so if you see anything dubious in the fork a bit later, when I've gotten it to works and such, do say something here, so that I can fix it before piling on a lot of work on a misguided version!

Somebodybro commented 3 months ago

I created a pullrequest for this!

https://github.com/firebase/firebase-admin-dotnet/pull/409

If there is any deeper discussion to be had about it, that cannot be handled within the pr comments, I think that can be had here?

Somebodybro commented 2 months ago

@lahirumaramba My pull request has been floating around for a while. If there is something wrong with it, i'm more than happy to keep working on it.