search

firebase / firebase-admin-go

Firebase Admin Go SDK
Apache License 2.0
1.13k stars 244 forks source link

Add support for Remote Config #396

Closed allentv closed 3 years ago

allentv commented 4 years ago

Summary This PR adds support for Remote Config based on the REST API reference. I ran these methods by invoking them from another file with service account credentials. Tests are pending.

Related Issue : https://github.com/firebase/firebase-admin-go/issues/391

hiranya911 commented 4 years ago

@lahirumaramba this needs to go through the API review process. I'd rather have an agreed upon API design before diving into the implementation.

allentv commented 4 years ago

@hiranya911 Let me know if you require me to fill out any documentation that would be useful for the review process.

hiranya911 commented 4 years ago

Hi @allenktv. Really appreciate you putting this together. I think it would be helpful if you can add an outline of the proposed public API to #391. Something similar in format to: https://github.com/firebase/firebase-admin-dotnet/issues/149#issuecomment-592145232

Then we can comment on it, and @lahirumaramba can also start the internal review process based on that.

lahirumaramba commented 3 years ago

Hi @allentv ! Please check the proposal I added to #391 When you get a chance, could you change the base branch of this PR to remote-config, please? That way once the code is updated to match the proposed API, we can merge your changes in. You do not have to implement the complete API. Thanks!

allentv commented 3 years ago

I have switched the based branch and made the proposed API spec changes

lahirumaramba commented 3 years ago

@allentv I reconsidered the changes. I think this looks good as it is. Please fix the build errors and we should be good to merge it to the feature branch. That way there will be minimal changes to make. Thanks again for your contribution!

allentv commented 3 years ago

@lahirumaramba Thanks for the feedback on how to fix those errors. I have made the changes and checks have passed. Appreciate your patience with this.