firebase / firebase-admin-go

Firebase Admin Go SDK
Apache License 2.0
1.13k stars 244 forks source link

feat(auth): Add enableAnonymousUser param to CreateTenant and UpdateTenant #412

Closed sonatard closed 2 years ago

sonatard commented 3 years ago

411

372

"https://identitytoolkit.googleapis.com/v2beta1" does not support enableAnonymousUser param. use "https://identitytoolkit.googleapis.com/v2".

RELEASE NOTE: Allowed enabling of anonymous provider via tenant configuration

google-cla[bot] commented 3 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

sonatard commented 3 years ago

@googlebot I signed it!

sonatard commented 3 years ago

https://github.com/firebase/firebase-admin-go/issues/411#issuecomment-724946065

@bojeil-google @rsgowman How is the progress of this plan?

sonatard commented 2 years ago

@bojeil-google @rsgowman Is there any problem with this pull request? I'm having trouble because I need this feature.

hiranya911 commented 2 years ago

This was proposed and added to the Node.js SDK: https://firebase.google.com/docs/reference/admin/node/admin.auth.Tenant#anonymoussigninenabled

I don't think it's been approved for the Go SDK yet.

sonatard commented 2 years ago

Node.js SDK was released 8 months ago.

https://github.com/firebase/firebase-admin-node/pull/802 https://github.com/firebase/firebase-admin-node/releases/tag/v9.5.0

sonatard commented 2 years ago

@lahirumaramba Thank you for your review !! I fixed it.

lahirumaramba commented 2 years ago

Hi @sonatard Thank you for updating the PR! It looks like there are some lint issues. Please take a look at https://github.com/firebase/firebase-admin-go/runs/5699483758?check_suite_focus=true

I think your changes to go.sum cause the other CI failures. You should be able to fix them by running go mod download golang.org/x/lint or by just excluding the changes to go.sum from this PR.

sonatard commented 2 years ago

@lahirumaramba I executed go mod download golang.org/x/lint.

sonatard commented 2 years ago

@lahirumaramba I found CI failed. Is there anything that I need to do? Fix format?

lahirumaramba commented 2 years ago

Hi, @sonatard Thank you for addressing the PR feedback! Could you fix the formatting issues, please? You should be able to see them locally if you run gofmt -l -s .. Thank you!

sonatard commented 2 years ago

@lahirumaramba I fixed format 👍

sonatard commented 2 years ago

@lahirumaramba Thank you for your kind communication. I have had a very pleasant experience since the review began. I’m so excited to release it!

lahirumaramba commented 2 years ago

Thank you @sonatard for your contribution! This feature is now released in v4.8.0

sonatard commented 2 years ago

Thanks!!