search

firebase / firebase-admin-go

Firebase Admin Go SDK
Apache License 2.0
1.13k stars 242 forks source link

feat(auth): enables OIDC Auth code flow #450

Closed ScruffyProdigy closed 2 years ago

ScruffyProdigy commented 3 years ago

Provides an option for developers to specify the OAuth response type for their OIDC provider (either one of these can be set:):

google-cla[bot] commented 3 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

ScruffyProdigy commented 3 years ago

@hiranya911

googlebot commented 3 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

googlebot commented 3 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

hiranya911 commented 3 years ago

Hi @ScruffyProdigy. This seems to have a badly broken commit history, which is also confusing the CLA check. Can I ask you to submit a new PR with a clean history? Since you're working on a fork, the workflow would look something like this:

# Assuming firebase/firebase-admin-go has already been set as an upstream...
git fetch upstream
git checkout --track upstream/dev

# Make your code changes on the dev branch

# Push the changes to your fork
git push origin dev

# Now should be possible to create a PR from your dev branch to ours
# (Remember to set the base branch to dev when creating the PR from the web UI)

Let me know if it's not working out, and I can use an admin override to ignore the CLA check and review this PR.