fix(fcm): Remove retry on 500 errors in the default config

firebase / firebase-admin-go

Firebase Admin Go SDK

Apache License 2.0

1.13k stars 242 forks source link

fix(fcm): Remove retry on 500 errors in the default config #453

Closed chong-shao closed 3 years ago

chong-shao commented 3 years ago

Remove retry on 500 errors in the default config.

Google Cloud documentation has been updated to not consider 500 as a retryable error code. Update Admin SDK to align with that

hiranya911 commented 3 years ago

Hi @chong-shao. This should be drafted against the dev branch, since we don't directly merge to master in this repo. Can you see if you can edit the PR, and change the base branch to dev?

chong-shao commented 3 years ago

Changed this pull request to merge to dev