search

firebase / firebase-admin-go

Firebase Admin Go SDK
Apache License 2.0
1.13k stars 242 forks source link

FR: Have GetUser return ExportedUserRecord #457

Open derekperkins opened 3 years ago

derekperkins commented 3 years ago

[REQUIRED] Step 2: Describe your environment

[REQUIRED] Step 3: Describe the problem

Steps to reproduce:

The only way to retrieve password information for a user is to run client.Users() and iterate through every user in the system. I am trying to get the password details for a single user, but GetUser doesn't return an ExportedUserRecord

hiranya911 commented 3 years ago

This is by design. Why do you want the GetUser() to return password information? There's no typical use case that would require that.

derekperkins commented 3 years ago

It requires significant workarounds to have the Firebase UID match the UID in our internal systems because it is auto-creating users. When a new user signs in, we grab all their user/provider information, delete that user and then import it again with all the same details except with a new UID. If there is a better way to do that, I'd love to hear.

hiranya911 commented 3 years ago

@bojeil-google WDYT? Seems like a selective export use case.

@derekperkins would it be possible to maintain the mapping between Firebase UIDs and your internal UIDs in Firestore instead?

derekperkins commented 3 years ago

It's possible, but not something we want to do. That requires a lookup on every single auth operation vs just setting it correctly on signup.

derekperkins commented 3 years ago

Getting password details is protected by its own iam permission, so IMO that should govern whether or not the password is returned. I'm not sure if it is the Firebase API itself that only returns the password details on a list call or the Go SDK making a decision on whether to expose some api response fields.

hiranya911 commented 3 years ago

All our Admin SDKs distinguish between UserRecord and ExportedUserRecord types. And currently only the "list" operation is meant to return ExportedUserRecord.

derekperkins commented 2 years ago

Does the api itself return the password data on other calls?

I'll also reiterate - my real issue is how to supply the UID to Firebase, so making the UID updateable would fix everything. This is just trying to make the workaround less terrible. Do you know if the List call returns newest users first? At least that would mean that I'm not iterating through 100% of our users on every new signup, likely just the first handful.

bojeil-google commented 2 years ago

FYI @prameshj