search

firebase / firebase-admin-go

Firebase Admin Go SDK
Apache License 2.0
1.12k stars 239 forks source link

fix(auth): Allow to update MFA #530

Closed brokeyourbike closed 10 months ago

brokeyourbike commented 1 year ago

Fixes #529.

RELEASE NOTE: Allow updating multi factor enrollments in UpdateUser() API

brokeyourbike commented 1 year ago

@lahirumaramba @hiranya911 👋

prameshj commented 1 year ago

Thanks for the fix! @pragatimodi can you take a look too? This is a follow up to https://github.com/firebase/firebase-admin-go/pull/511, the fields in updateUser expect "mfa" rather than "mfaInfo". Thanks!

pragatimodi commented 1 year ago

Thanks for finding this fix!

prameshj commented 1 year ago

Thanks! I have one final nit, LGTM otherwise.

@lahirumaramba for final approval/merge.

brokeyourbike commented 1 year ago

can this be merged @lahirumaramba ?

brokeyourbike commented 1 year ago

Hi team, can you please take a look at the PR. I have made the changes as requested. @prameshj @lahirumaramba

brokeyourbike commented 1 year ago

Hello team, can we please move forward with this PR? Let me know if there is anything I should do @prameshj @pragatimodi @lahirumaramba

prameshj commented 1 year ago

Thanks for checking, Ivan! The changes look good to me. I think we only need @lahirumaramba to approve. Lahiru, can you help with this? Thanks!

brokeyourbike commented 11 months ago

Thank you for the update @prameshj @lahirumaramba can you please help with reviewing this PR? It's been in this state for over 6 month now

brokeyourbike commented 10 months ago

Are my proposed changes outdated and do not comply with expected release? Should I create a new PR and revisit what was done?

Please give at least some direction @prameshj @pragatimodi @lahirumaramba , thanks.

lahirumaramba commented 10 months ago

Thanks folks! We will include this in the next release.