firebase / firebase-admin-go

Firebase Admin Go SDK
Apache License 2.0
1.12k stars 239 forks source link

feat(fcm): Set FCMOptions for MulticastMessage #537

Closed FZambia closed 3 months ago

FZambia commented 1 year ago

Hello!

Currently it's impossible to set FCMOptions for MulticastMessage. While for example in Python admin SDK this is possible. And in Java admin SDK. This pull request fixes this.

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

FZambia commented 1 year ago

CLA signed

lahirumaramba commented 1 year ago

Hi @FZambia Thank you for your contribution. Please change the base branch to dev before we can start the review process.

https://github.com/firebase/firebase-admin-go/blob/master/CONTRIBUTING.md#want-to-submit-a-pull-request

Make sure to create all your pull requests against the dev branch. All development work takes place on this branch, while the master branch is dedicated for released stable code. This enables us to review and merge routine code changes, without impacting downstream applications that are building against our master branch.

FZambia commented 1 year ago

Hello team, could you please tell when this will be released?

FZambia commented 1 year ago

@lahirumaramba - any updates?

FZambia commented 6 months ago

Guys, at least explain what prevents you from merging this?

chong-shao commented 6 months ago

LGTM But I'd like to ask for waiting until @lahirumaramba 's review

sebastianbuechler commented 5 months ago

This would be nice to finally have in the package. @lahirumaramba can you please have a look at this minor change as it's only two lines of code and almost a year open?

FZambia commented 4 months ago

@lahirumaramba kindly reminding 🙏

lahirumaramba commented 3 months ago

Thanks folks! This change will be included in the next release

FZambia commented 3 months ago

Nice, many thanks!