Closed FZambia closed 3 months ago
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
CLA signed
Hi @FZambia Thank you for your contribution. Please change the base branch to dev
before we can start the review process.
Make sure to create all your pull requests against the
dev
branch. All development work takes place on this branch, while themaster
branch is dedicated for released stable code. This enables us to review and merge routine code changes, without impacting downstream applications that are building against our master branch.
Hello team, could you please tell when this will be released?
@lahirumaramba - any updates?
Guys, at least explain what prevents you from merging this?
LGTM But I'd like to ask for waiting until @lahirumaramba 's review
This would be nice to finally have in the package. @lahirumaramba can you please have a look at this minor change as it's only two lines of code and almost a year open?
@lahirumaramba kindly reminding 🙏
Thanks folks! This change will be included in the next release
Nice, many thanks!
Hello!
Currently it's impossible to set
FCMOptions
forMulticastMessage
. While for example in Python admin SDK this is possible. And in Java admin SDK. This pull request fixes this.