search

firebase / firebase-admin-go

Firebase Admin Go SDK
Apache License 2.0
1.12k stars 239 forks source link

Firebase Auth/Import Users: added a phone number to the user provider #541

Open mymyparty opened 1 year ago

mymyparty commented 1 year ago

This MR adds a phoneNumber field to the user provider struct. Related issue: https://github.com/firebase/firebase-admin-go/issues/540 There is no relevant existing test.

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

lahirumaramba commented 1 year ago

Hi @mymyparty Thank you for your contribution. Please change the base branch to dev before we can start the review process.

https://github.com/firebase/firebase-admin-go/blob/master/CONTRIBUTING.md#want-to-submit-a-pull-request

Make sure to create all your pull requests against the dev branch. All development work takes place on this branch, while the master branch is dedicated for released stable code. This enables us to review and merge routine code changes, without impacting downstream applications that are building against our master branch.

mymyparty commented 1 year ago

@lahirumaramba done

mymyparty commented 8 months ago

@lahirumaramba Hi! Any progress on this?