Open noahw3 opened 4 weeks ago
Hey @noahw3, thanks for reporting this! We need a complete error handling revamp in the SDK, but since that was not currently in the roadmap we merged #2549 as a stopgap. The constructors are currently marked as private... I will look into this issue to see what else we can to do improve the exposed error types
[READ] Step 1: Are you in the right place?
[REQUIRED] Step 2: Describe your environment
[REQUIRED] Step 3: Describe the problem
Steps to reproduce:
The new error types that are exported in 12.1.1 are great and make error handling much easier. However, the TS interfaces are notably lacking constructors - they just extend all the way to Error. The actual implementations take
info: ErrorInfo, message?: string
parameters to set the underlyingcode
andmessage
properties.This means that in testing code I'm not able to really take advantage of the new types without casting or playing other type shenanigans in order to set the properties as expected, which significantly limits the usefulness of these newly exported types.
Relevant Code:
Relates to https://github.com/firebase/firebase-admin-node/pull/2549