firebase / firebase-admin-node

Firebase Admin Node.js SDK
https://firebase.google.com/docs/admin/setup
Apache License 2.0
1.61k stars 363 forks source link

Usage of legacy API #2635

Closed rodolfoamarques closed 4 hours ago

rodolfoamarques commented 1 month ago

Describe your environment

Describe the problem

the messaging().send() method continues to utilise the old API even though it has been deprecated since 2023 and removed since June 2024 as per this documentation

Steps to reproduce:

Calls/Usage of the above method results in a TOPIC_MESSAGE_RATE_EXCEEDED error.

Relevant Code:

in this very repository we can find the following code:

const FCM_SEND_HOST = 'fcm.googleapis.com';
const FCM_SEND_PATH = '/fcm/send';
const FCM_TOPIC_MANAGEMENT_HOST = 'iid.googleapis.com';
const FCM_TOPIC_MANAGEMENT_ADD_PATH = '/iid/v1:batchAdd';
const FCM_TOPIC_MANAGEMENT_REMOVE_PATH = '/iid/v1:batchRemove';

According to the latest documentation, the API to be used should be https://fcm.googleapis.com/v1/projects/{PROJECT_ID}/messages:send

google-oss-bot commented 1 month ago

I found a few problems with this issue:

devj3ns commented 11 hours ago

related: https://github.com/firebase/firebase-admin-node/issues/2602

lahirumaramba commented 4 hours ago

Thanks @devj3ns !

Hey folks, please see my response in https://github.com/firebase/firebase-admin-node/issues/2602#issuecomment-2322053273

The deprecated endpoints mentioned in the issue are being used in sendToTopic and sendToCondition` APIs. These APIs are now deprecated in v12.4.0+