hiranya911
commented
4 years ago I'm not able to reproduce this. I can send very large volumes of messages (tested with up to 10K) with no impact on memory usage. Also the FCM code (especially the legacy code) hasn't changed between v7 and v8, so there' no reason why it would cause a memory leak. Are you using any other APIs (Firestore for example, which has a known memory leak issue in latest versions)?
Here are my test results:
const admin = require('firebase-admin');
function toMB(bytes) {
return Math.round(bytes / 1024 / 1024 * 100) / 100;
}
function heapStats() {
const used = process.memoryUsage();
return `[ HEAP: ${toMB(used.heapUsed)} MB, RSS: ${toMB(used.rss)} MB ]`;
}
function sendMulticast(tokens) {
const msg = {
data: {key: 'value'},
tokens,
}
return admin.messaging().sendMulticast(msg, true);
}
const app = admin.initializeApp();
const BATCHES = 100;
console.log('Starting application:', heapStats());
const promises = [];
for (let i = 0; i < BATCHES; i++) {
const tokens = [];
for (let j = 0; j < 100; j++) {
tokens.push(`fake.token.${j}`);
}
promises.push(sendMulticast(tokens));
}
console.log(`Started ${BATCHES} batches:`, heapStats());
Promise.all(promises)
.then((results) => {
const total = results.map(r => r.responses.length).reduceRight((a, b) => a + b, 0);
console.log(`Done sending ${total}:`, heapStats());
})
.catch((err) => {
console.log(err);
})
.then(() => {
global.gc();
console.log('Garbage collected:', heapStats());
return app.delete();
})
.then(() => {
console.log('\nDONE');
});Output for 10K messages:
Starting application: [ HEAP: 7.91 MB, RSS: 29.1 MB ]
Started 100 batches: [ HEAP: 11.28 MB, RSS: 40.91 MB ]
Done sending 10000: [ HEAP: 52.83 MB, RSS: 121.43 MB ]
Garbage collected: [ HEAP: 8.57 MB, RSS: 100.57 MB ]Notice how the heap grows from 8MB to 53MB, but then shrinks after GC had a chance to run. Can you share your function or see if you can reproduce the issue with a similar, simplified test application?
0x80
dougg0k
[REQUIRED] Step 2: Describe your environment
[REQUIRED] Step 3: Describe the problem
I have a cloud function which used the old FCM API
sendToDevice(). Then upgrading firebase-admin from 6 to 8 I started to get into trouble because if what appears to be a memory-leak.I have updated the function to use the new FCM
sendMulticast()method. This didn't change anything to the leak. I have also tried deploying to both node 8 and 10 functions, but this made no difference.When I downgraded to firebase-admin v7 the problem went away.
In the attached image you can clearly see when I upgraded and downgraded back to 7.
In the second half of the leaking you see a more defined saw tooth pattern, but that is the result of me optimising the code so that the amount of messages sent is limited to 2k users. As a result it leaks less memory and the build-up is slower and more consistent.
When the function hits the maximum of 2GB then it crashes (usually with a vague error like:
or
Steps to reproduce:
Use sendToDevice or sendMulticast to send lots of messages. The more you sent the more pronounced the leak will be. Try 5k and it quickly runs over the 2GB limit.