search

firebase / firebase-admin-python

Firebase Admin Python SDK
https://firebase.google.com/docs/admin/setup
Apache License 2.0
1.02k stars 315 forks source link

#678 fixed removing email from userRecord via update_user #744

Open smithlauren910 opened 9 months ago

smithlauren910 commented 9 months ago

Discussion

This PR resolves issue https://github.com/firebase/firebase-admin-python/issues/678.

Testing

Suggestions are welcomed for further testing.

Adeline09 commented 9 months ago

Description of changes: In firebase_admin/_user_mgt.py we changed the email validation in the payload to include the condition that checks whether email should be deleted via DELETE_ATTRIBUTE. Also we wrote the function to delete email from the database upon checking DELETE_ATTRIBUTE.

Description of tests: In tests/test_user_mgt.py we included corresponding fields for email in the function test_update_user_delete_fields. Then we wrote the function test_update_user_delete_provider_and_email that verifies email deletion from the database in the same manner as phone number deletion.

prameshj commented 9 months ago

cc @renkelvin