search

firebase / firebase-admin-python

Firebase Admin Python SDK
https://firebase.google.com/docs/admin/setup
Apache License 2.0
988 stars 300 forks source link

Update release and ci workflows to use `GITHUB_OUTPUT` and bump `actions/checkout` to v4. #752

Closed jonathanedey closed 5 months ago

jonathanedey commented 5 months ago

Currently we use a forked version of a (no longer maintained) release github action which still uses set-output: https://github.com/firebase/firebase-admin-python/blob/master/.github/workflows/release.yml#L110

Would we want to consider moving this to a new maintained source like https://github.com/ncipollo/release-action?

lahirumaramba commented 5 months ago

Currently we use a forked version of a (no longer maintained) release github action which still uses set-output: https://github.com/firebase/firebase-admin-python/blob/master/.github/workflows/release.yml#L110

Would we want to consider moving this to a new maintained source like https://github.com/ncipollo/release-action?

good call! I think we should. Let's do it in a separate PR though. Is there an official github action for this now?

jonathanedey commented 5 months ago

good call! I think we should. Let's do it in a separate PR though. Is there an official github action for this now?

The original repo the fork was based on was the official one until they stopped maintaining it in 2021.

They left suggested alternatives with the one i linked being the most active but the thread of mentions shows a few repos who decided to use https://github.com/softprops/action-gh-release instead.