search

firebase / firebase-android-sdk

Firebase Android SDK
https://firebase.google.com
Apache License 2.0
2.23k stars 565 forks source link

Tomandersen/handshake rewrite #6015

Open tom-andersen opened 3 weeks ago

github-actions[bot] commented 3 weeks ago
Javadoc Changes: ```diff --- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/firestore/FirebaseFirestore.html 2024-06-19 16:44:01.222773203 +0000 +++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/firestore/FirebaseFirestore.html 2024-06-19 16:41:29.828085746 +0000 @@ -167,7 +167,7 @@ - synchronized @Nullable PersistentCacheIndexManager + @Nullable PersistentCacheIndexManager
getPersistentCacheIndexManager()

Gets the PersistentCacheIndexManager instance used by this FirebaseFirestore object.

@@ -790,7 +790,7 @@

getPersistentCacheIndexManager

- 
synchronized public @Nullable PersistentCacheIndexManager getPersistentCacheIndexManager()
+ 
public @Nullable PersistentCacheIndexManager getPersistentCacheIndexManager()

Gets the PersistentCacheIndexManager instance used by this FirebaseFirestore object.

This is not the same as Cloud Firestore Indexes. Persistent cache indexes are optional indexes that only exist within the SDK to assist in local query execution.

```
github-actions[bot] commented 3 weeks ago

Unit Test Results

  8 files   -    176    8 suites   - 176   1m 12s :stopwatch: - 3m 13s 12 tests  - 1 218  12 :heavy_check_mark:  - 1 202  0 :zzz:  - 16  0 :x: ±0  24 runs   - 2 460  24 :heavy_check_mark:  - 2 428  0 :zzz:  - 32  0 :x: ±0 

Results for commit e61b1ed8. ± Comparison against base commit 1cbaac15.

:recycle: This comment has been updated with latest results.

google-oss-bot commented 3 weeks ago
1 Warning
:warning: Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by :no_entry_sign: Danger

google-oss-bot commented 3 weeks ago

<!DOCTYPE html>

Coverage Report 1

Affected Products

No changes between base commit (6d0f288) and merge commit (d5cde9c).

Test Logs

google-oss-bot commented 2 weeks ago

<!DOCTYPE html>

Size Report 1

Affected Products

  • base

    TypeBase (1cbaac1)Merge (46ce541)Diff
    apk (aggressive)?8.80 kB? (?)
    apk (release)?9.77 kB? (?)

  • firebase-firestore

    TypeBase (1cbaac1)Merge (46ce541)Diff
    aar?1.45 MB? (?)
    apk (aggressive)?554 kB? (?)
    apk (release)?11.1 MB? (?)

  • protolite-well-known-types

    TypeBase (1cbaac1)Merge (46ce541)Diff
    aar?1.01 MB? (?)
    apk (aggressive)?134 kB? (?)
    apk (release)?1.68 MB? (?)

Test Logs