firebase / firebase-android-sdk

Firebase Android SDK
https://firebase.google.com
Apache License 2.0
2.23k stars 565 forks source link

Changing caught exception type to fail safely on any exception type. #6022

Closed anitdas closed 2 weeks ago

anitdas commented 3 weeks ago

Addressing issue #6001. This will avoid failing on the early upload and instead report the errors with either the next scheduled time by Firelog, or the next app launch

github-actions[bot] commented 3 weeks ago

πŸ“ PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

google-oss-bot commented 3 weeks ago
1 Warning
:warning: Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by :no_entry_sign: Danger

google-oss-bot commented 3 weeks ago

<!DOCTYPE html>

Coverage Report 1

Affected Products

No changes between base commit (b770489) and merge commit (c8e5057).

Test Logs

github-actions[bot] commented 3 weeks ago

Unit Test Results

βŸβ€„6 files  +βŸβ€„6β€‚β€ƒβŸβ€„6 suites  +6   20s :stopwatch: +20s 19 tests +19  19 :heavy_check_mark: +19  0 :zzz: Β±0  0 :x: Β±0  38 runs  +38  38 :heavy_check_mark: +38  0 :zzz: Β±0  0 :x: Β±0 

Results for commit a6c56a4d. ± Comparison against base commit b770489c.