search

firebase / firebase-android-sdk

Firebase Android SDK
https://firebase.google.com
Apache License 2.0
2.23k stars 565 forks source link

Update gRPC to 1.64.0 #6048

Open larssn opened 1 week ago

larssn commented 1 week ago

Hello

The current version (1.57.2) is almost a year old, so I request an update to 1.64.0 (latest as of writing).

We're seeing what seemingly is gRPC specific errors recently (downstream in Flutter), so I'm hoping something has been fixed in the last year, regarding this. The error is: [cloud_firestore/internal] Internal errors. Means some invariants expected by underlying system has been broken. If you see one of these errors, something is very broken.

I've also created an issue over at java-firestore: https://github.com/googleapis/java-firestore/issues/1708

google-oss-bot commented 1 week ago

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

lehcar09 commented 1 week ago

Hi @larssn, thank you for reaching out. I'll inform our engineers about this. In the meantime, you can actually specify the grpc dependency explicitly and it should override the version bundled in firestore.

Could you check if this resolves the issue you're experiencing?

implementation 'io.grpc:grpc-android:1.64.0'
implementation 'io.grpc:grpc-okhttp:1.64.0'
implementation 'io.grpc:grpc-protobuf-lite:1.64.0'
implementation 'io.grpc:grpc-stub:1.64.0'
google-oss-bot commented 3 days ago

Hey @larssn. We need more information to resolve this issue but there hasn't been an update in 5 weekdays. I'm marking the issue as stale and if there are no new updates in the next 5 days I will close it automatically.

If you have more information that will help us get to the bottom of this, just add a comment!

larssn commented 3 days ago

To prevent the bot from aggressively closing: Thanks for the workaround!

tom-andersen commented 19 hours ago

Hi @larssn

Upgrading gRPC was held back due to Firebase support of older devices. Two months ago, we upped the min SDK version of Android to 21, which now makes upgrading gRPC possible.

I have created a PR to make this upgrade: https://github.com/firebase/firebase-android-sdk/pull/6062