Closed mrober closed 1 month ago
github-actions[bot]
commented
1 month ago No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).
google-oss-bot
commented
1 month ago <!DOCTYPE html>
firebase-crashlyticsOverall coverage changed from 11.13% (08deb69) to 11.27% (ee12c98) by +0.14%.
| Filename | Base (08deb69) | Merge (ee12c98) | Diff |
|---|---|---|---|
| CrashlyticsController.java | 16.58% | 16.18% | -0.40% |
| CrashlyticsCore.java | 0.61% | 0.61% | -0.00% |
| CrashlyticsWorker.java | 30.30% | 23.26% | -7.05% |
| CrashlyticsWorkers.kt | ? | 26.32% | ? |
| DataCollectionArbiter.java | 83.33% | 84.27% | +0.94% |
github-actions[bot]
commented
1 month ago 8 files - 178 8 suites - 178 27s :stopwatch: - 4m 12s 22 tests - 1 212 22 :heavy_check_mark: - 1 196 0 :zzz: - 16 0 :x: ±0 44 runs - 2 448 44 :heavy_check_mark: - 2 416 0 :zzz: - 32 0 :x: ±0
Results for commit 03fb48d4. ± Comparison against base commit 08deb691.
:recycle: This comment has been updated with latest results.
google-oss-bot
commented
1 month ago <!DOCTYPE html>
firebase-crashlytics| Type | Base (08deb69) | Merge (ee12c98) | Diff |
|---|---|---|---|
| aar | 417 kB | 410 kB | -6.71 kB (-1.6%) |
| apk (aggressive) | 697 kB | 698 kB | +716 B (+0.1%) |
| apk (release) | 5.85 MB | 5.85 MB | -4.70 kB (-0.1%) |
google-oss-bot
commented
1 month ago <!DOCTYPE html>
Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.
fire-cls| Device | Statistics | Distributions | ||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| oriole-32 |
20 test runs in comparison
|  | ||||||||||||||||||||||||||||||||||||
| redfin-30 |
20 test runs in comparison
|  |
fire-rc| Device | Statistics | Distributions | ||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| oriole-32 |
20 test runs in comparison
|  | ||||||||||||||||||||||||||||||||||||
| redfin-30 |
20 test runs in comparison
|  |
fire-sessions| Device | Statistics | Distributions | ||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| oriole-32 |
20 test runs in comparison
|  | ||||||||||||||||||||||||||||||||||||
| redfin-30 |
20 test runs in comparison
|  |
timeToInitialDisplay| Device | Statistics | Distributions | ||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| oriole-32 |
20 test runs in comparison
|  | ||||||||||||||||||||||||||||||||||||
| redfin-30 |
20 test runs in comparison
|  |
mrober
commented
1 month ago
Add a CrashlyticsWorkers container to manage the workers, and define what each one is for. Also added a
submitTaskOnSuccessmethod for convenience. This will be useful for any of the user actions that get triggered by send unsent reports.Also found and fixed a bug in the worker queue. If a task gets cancelled and is followed by a runnable or callable already in the queue, it would have been skipped. Now it's not a problem, and a test case added.