firebase / firebase-android-sdk

Firebase Android SDK
https://firebase.google.com
Apache License 2.0
2.26k stars 573 forks source link

DataConnectGrpcMetadata.kt: Omit x-firebase-gmpid if appId is empty or blank (i.e. contains only whitespace characters) #6200

Closed dconeybe closed 1 month ago

dconeybe commented 1 month ago

See for rationale: https://github.com/firebase/firebase-js-sdk/pull/4810

google-oss-bot commented 1 month ago
1 Warning
:warning: Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by :no_entry_sign: Danger

google-oss-bot commented 1 month ago

<!DOCTYPE html>

Coverage Report 1

Affected Products

Test Logs

github-actions[bot] commented 1 month ago

Unit Test Results

  36 files    36 suites   1m 12s :stopwatch: 328 tests 328 :heavy_check_mark: 0 :zzz: 0 :x: 656 runs  656 :heavy_check_mark: 0 :zzz: 0 :x:

Results for commit 523c2ece.

google-oss-bot commented 1 month ago

<!DOCTYPE html>

Size Report 1

Affected Products

Test Logs